Feature/py3k #2
Closed
Feature/py3k #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes py3 and makes precedence more explicit
A 1000 integer array isn't big enough to cause problems
Contributor
|
Hi @bwhmather, thanks for the contribution. I'm sure making this 2/3 compatible had some headaches associated with it :) Unfortunately, things are rather slow at the moment during the holiday break, but we'll definitely do a thorough review early in the new year. |
Author
|
Thank you and no problem. I'm also working on another branch that replaces the JWA object with separate lookup functions for different algorithms that will hopefully be worth looking at when you have time. Merry Christmas |
Contributor
|
Hi @bwhmather thanks for your work on this. I've opened a new PR #15 which provides Python 3 support using six. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have mostly adapted the jose package to work with python 3 (in addition to python 2).
Getting tests running with multiple versions of python has necessitated rearanging some of the files but I believe that I have managed to avoid breaking the current api.
There is one remaining problem which is that I can't figure out what format the key for hmac algorithms should be in and therefore whether, and where, it should be encoded as bytes or unicode. Will have another look at fixing it now. This problem does not affect python 2 however.
I do have to say that the excellent test suite has made this really quite easy. Thank you.