-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade Deps #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade Deps #69
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates a set of runtime and tooling dependencies in package.json (and the corresponding pnpm-lock.yaml) to newer minor/patch versions, without any application code changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `package.json:58` </location>
<code_context>
"eslint-plugin-react-hooks": "4.3.0",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"prettier": "2.8.7",
"rollup-plugin-copy": "3.4.0",
</code_context>
<issue_to_address>
**issue (testing):** Align `jest-environment-jsdom` major version with the Jest runtime to avoid subtle test issues.
Jest is still on 29.x while `jest-environment-jsdom` is on 30.x, and these packages are typically version-locked. Mixing majors can cause subtle runtime mismatches (e.g., globals setup/teardown or API compatibility). Please either upgrade Jest to 30.x as well or pin `jest-environment-jsdom` to 29.x to match.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Build for commit f29d57a deployed to: https://docusign-pr-69.ci.next.deskprodemo.com URLs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates multiple dependencies to their latest versions, improving stability, security, and compatibility of the application. The updates include both production dependencies for runtime functionality and development dependencies for the build toolchain.
- Production dependencies upgraded: Sentry SDK, TanStack Query, React Hook Form, and React Router
- Development dependencies upgraded: SWC compiler, TypeScript, Vite, testing utilities, and styled-components
- All updates follow semantic versioning with minor and patch version increments
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates dependency versions for production and development packages |
| pnpm-lock.yaml | Reflects the updated dependency tree with new version resolutions and transitive dependencies |
Based on my review, all dependency updates appear to be minor or patch version updates following semantic versioning. The changes look appropriate for a maintenance update. No critical issues were identified.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request updates several dependencies in the
package.jsonfile, bringing both production and development packages to their latest versions for improved stability, security, and compatibility.Dependency updates:
Production dependencies:
@sentry/react,@tanstack/react-query,react-hook-form, andreact-router-domto their latest versions.Development dependencies:
@swc/core,@swc/helpers,@types/react,jest-environment-jsdom,styled-components,typescript, andviteto newer versions. [1] [2]Summary by Sourcery
Update frontend application dependencies to newer versions for stability and compatibility.
Build: