[feature] SC-166737/improve app proxy security by restricting where token replacements can go #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken replacements can go
There was a problem hiding this comment.
Pull Request Overview
This PR enhances security for the Mailchimp app by adding settingsInjection configuration to the proxy whitelist, ensuring sensitive OAuth credentials are properly injected into API requests in a controlled manner.
Key Changes:
- Added
settingsInjectionconfiguration to control how sensitive settings are injected into proxy requests - Configured OAuth endpoint to inject
client_idandclient_secretinto request body fields - Added empty
settingsInjectionobject to main API endpoint for future extensibility
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build for commit 8bebaf2 deployed to: https://mailchimp-pr-63.ci.next.deskprodemo.com URLs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an update to the Mailchimp API configuration in the
manifest.jsonfile. The main change is the addition of asettingsInjectionproperty to improve how sensitive settings like OAuth credentials are handled.Configuration improvements for Mailchimp API:
settingsInjectionobject to the main Mailchimp API endpoint configuration to support future extensibility.settingsInjectionobject to the OAuth endpoint configuration, specifying thatclient_idandclient_secretshould be injected into the request body for authentication purposes.