[feature] SC-166737/improve app proxy security by restricting where token replacements can go #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken replacements can go
|
Build for commit 2e36040 deployed to: https://surveymonkey-pr-55.ci.next.deskprodemo.com URLs: |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances security for the SurveyMonkey app by restricting where API key token replacements can occur during proxy requests. The change configures the app to only inject the API key into the Authorization header, preventing potential security issues from unrestricted token injection.
Key Changes:
- Added
settingsInjectionconfiguration to the proxy whitelist entry for SurveyMonkey API endpoints - Specified that the
api_keysetting should only be injected into theAuthorizationheader
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a configuration update to the
manifest.jsonfile, enhancing how API keys are injected into outgoing requests to the SurveyMonkey API.API key injection improvement:
settingsInjectionblock to the SurveyMonkey API configuration, specifying that theapi_keyshould be included in theAuthorizationheader for requests.