Upgrade Deps #79
Open
Upgrade Deps #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR updates application and tooling dependencies in package.json (and the corresponding pnpm-lock.yaml) to newer patch/minor versions, primarily for UI, routing, form handling, Sentry integration, SWC/Jest/testing libraries, TypeScript, Vite, and related type definitions, without any code changes to the app itself. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `package.json:70` </location>
<code_context>
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
- "prettier": "^3.6.2",
+ "jest-environment-jsdom": "^30.2.0",
+ "prettier": "^3.7.4",
"resize-observer-polyfill": "^1.5.1",
</code_context>
<issue_to_address>
**issue (testing):** Check Jest / jest-environment-jsdom major-version alignment to avoid subtle test runtime issues.
`jest` is still on 29.x (`"jest": "^29.7.0"`), while `jest-environment-jsdom` is now 30.x. These packages typically share a major version, and mixing them can cause subtle test failures or API mismatches. Please confirm 30.x explicitly supports Jest 29; if not, keep `jest-environment-jsdom` on a 29.x-compatible version or upgrade Jest (and related tooling like `ts-jest`) in lockstep.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Build for commit d02edf4 deployed to: https://teamviewer-pr-79.ci.next.deskprodemo.com URLs: |
There was a problem hiding this comment.
Pull request overview
This pull request updates multiple dependencies and devDependencies to their latest versions, including core libraries like React testing utilities, build tools, and development tooling. The updates appear to be primarily minor and patch version upgrades, maintaining backward compatibility.
Key Changes
- Updated testing libraries (@testing-library/dom, @testing-library/jest-dom, jest-environment-jsdom)
- Upgraded build and development tools (@swc/core, @vitejs/plugin-react, vite, typescript)
- Updated core dependencies (@deskpro/deskpro-ui, @sentry packages, @tanstack/react-query, react-hook-form, styled-components)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates dependency versions for both production and development packages |
| pnpm-lock.yaml | Reflects resolved dependency versions and transitive dependencies from package.json updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates several dependencies and devDependencies in the
package.jsonfile to their latest versions. The updates include both core libraries and development tools, which should help keep the project secure and compatible with the latest features and bug fixes.Dependency updates:
@deskpro/deskpro-ui,@sentry/react,@sentry/vite-plugin,@tanstack/react-query,react-hook-form,react-router-dom,simplebar, andstyled-componentsto their latest versions.Development tooling updates:
@swc/core,@swc/helpers,@testing-library/dom,@testing-library/jest-dom,@types/lodash,@types/react,@vitejs/plugin-react,jest-environment-jsdom,prettier,ts-jest,typescript, andviteto newer versions.Summary by Sourcery
Update runtime and tooling dependencies to newer minor and patch versions.
Build:
Chores: