Skip to content

Conversation

@HappyPaul55
Copy link
Contributor

@HappyPaul55 HappyPaul55 commented Feb 9, 2025

Evidence

zoom-demo.mp4

This PR updates the OAuth2 implementation to use the latest features from @deskpro/app-sdk v6.0.3.

Changes made:

  1. Upgraded @deskpro/app-sdk from 5.1.1 to 6.0.3
  2. Updated the OAuth2 implementation to use the new SDK features:
    • Replaced the old oauth2() method with startOauth2Local
    • Updated the code to handle the new OAuth2 flow
    • Fixed TypeScript types to match the new SDK requirements
    • Improved error handling
  3. Simplified the code by:
    • Removing unnecessary state management
    • Using async/await consistently
    • Extracting callback URL from the authorization URL
    • Improving type safety

@github-actions
Copy link

github-actions bot commented Feb 9, 2025

@HappyPaul55 HappyPaul55 marked this pull request as ready for review February 10, 2025 10:21
AFOJ
AFOJ previously approved these changes Feb 10, 2025
@HappyPaul55 HappyPaul55 changed the title Update OAuth2 implementation to use latest app-sdk features [Feature] SC-180573 Update OAuth2 implementation to use latest app-sdk features Feb 10, 2025
@HappyPaul55 HappyPaul55 requested a review from a team as a code owner February 10, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants