fix: add missing python dependency resources #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add resource blocks for requests and its dependencies: - certifi, charset-normalizer, idna, requests, urllib3 This fixes "ModuleNotFoundError: No module named 'requests'" on fresh installs. The formula was using pip_install_and_link which doesn't resolve dependencies from package metadata. Now explicitly declares all required resources. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
SkPhilipp
approved these changes
Jan 26, 2026
Member
SkPhilipp
left a comment
SkPhilipp
left a comment
There was a problem hiding this comment.
OK but cleaner would be to generate them as we previously did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add resource blocks for
requestsand its dependencies to fix missing module errors on fresh installs.Problem
The formula used
venv.pip_install_and_link buildpathwhich installs the package but doesn't resolve dependencies, causing:Solution
venv.pip_install resourcesbefore installing the main packageTest plan
devleaps-policy-client --helpsucceedsdevleaps-policy-client installworksFixes the issue where dependencies weren't being installed from the venv.
🤖 Generated with Claude Code