Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 1, 2025

Description

Addresses review feedback from #14: the volume variable was calculated but never used.

Fixed by including the workspace volume in the log output alongside the existing axis dimension information:

logger.log_info(
    f"Computed Cartesian workspace bounds from {len(workspace_pts)} FK samples:\n"
    f"\t X-axis: [{min_bounds_np[0]:.3f}, {max_bounds_np[0]:.3f}] m (range: {dimensions[0]:.3f} m)\n"
    f"\t Y-axis: [{min_bounds_np[1]:.3f}, {max_bounds_np[1]:.3f}] m (range: {dimensions[1]:.3f} m)\n"
    f"\t Z-axis: [{min_bounds_np[2]:.3f}, {max_bounds_np[2]:.3f}] m (range: {dimensions[2]:.3f} m)\n"
    f"\t Volume: {volume:.3f} m³"
)

Fixes feedback from #14 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

N/A - logging output change only.

Checklist

  • I have run the black . command to format the code base.
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Dependencies have been updated, if applicable.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: chase6305 <61959467+chase6305@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on workspace analyzer and user docs PR Fix unused volume variable in workspace analyzer Dec 1, 2025
Copilot AI requested a review from chase6305 December 1, 2025 02:04
@chase6305 chase6305 marked this pull request as ready for review December 1, 2025 02:44
@chase6305 chase6305 merged commit 05485b2 into cjt/add_workspace_analyzer Dec 1, 2025
@chase6305 chase6305 deleted the copilot/sub-pr-14 branch December 1, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants