Allow toggling of sim behaviour #56
Conversation
ptsOSL
force-pushed
the
toggle-sim-behaviour
branch
2 times, most recently
from
a11ec27 to
fbabe15
Compare
Allow selecting linopt function, disabling chromaticity aand disabling radiation
Also fix some tests which were broken by reordering of function arguments
ptsOSL
force-pushed
the
toggle-sim-behaviour
branch
from
fbabe15 to
0a27483
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 86.73% 85.84% -0.89%
==========================================
Files 6 6
Lines 392 431 +39
==========================================
+ Hits 340 370 +30
- Misses 52 61 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The CI is failing after python 3.11 due to a cothread seg fault. These version of cothread are known to be unreliable so, remove support for python 3.12 and 3.13 until after we have switched from cothread to asyncio
|
I had to remove support for python 3.12 and python 3.13 as the tests were causing cothread to segfault. As we will shortly be switching to asyncio I think it is better to just stop supporting these python versions rather than figuring out what is causing the seg fault. After the switch we can support them again. |
There will be a corresponding update to Virtac
We now use enable_6d instead of the misleading radiation_on, enable_6d is only called for linopt6. Also modify the validation exceptions to be more accurate
This will mean that post_init is called if anyone later modifies the attributes of the dataclass. This ensure validation always
Now that disabling emittance on an existing ATSimulator isnt supported, it makes more sense to have two seperate tests one which tests a simulator with and one without emittance disabled. Rather than testing both at once
There was a problem hiding this comment.
I don't think the tests are perfect, but after discussing this seems like a reasonable improvement over the original ones.
It would be good to distinguish between coverage and other failures in the CI, but I don't know how much of a pain that is with the copier template. I'll make sure to double check cause of failures in instances like this, in future.
Waiting for the diamond2-conversion merge into main to happen first.