Skip to content

Conversation

@oliwenmandiamond
Copy link
Contributor

@oliwenmandiamond oliwenmandiamond commented Nov 28, 2025

Fixes #ISSUE

$ dodal connect i05_shared
Attempting connection to i05_shared (using dodal.beamlines.i05_shared)
5 devices connected:
        id
        id_gap
        id_phase
        pgm
        synchrotron
$ dodal connect i05
Attempting connection to i05 (using dodal.beamlines.i05)
6 devices connected:
        id
        id_gap
        id_phase
        pgm
        sm
        synchrotron
$ dodal connect i05-1
Attempting connection to i05-1 (using dodal.beamlines.i05_1)
6 devices connected:
        id
        id_gap
        id_phase
        pgm
        sm
        synchrotron

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@oliwenmandiamond oliwenmandiamond force-pushed the i05_example_shared_beamline_structure branch from 23843cb to 4dd49c0 Compare November 28, 2025 12:51
@oliwenmandiamond oliwenmandiamond changed the base branch from main to i03-device-manager November 28, 2025 12:52
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.09%. Comparing base (2cdee61) to head (7076edd).

Files with missing lines Patch % Lines
src/dodal/device_manager.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1741      +/-   ##
==========================================
- Coverage   99.10%   99.09%   -0.01%     
==========================================
  Files         279      279              
  Lines       10510    10521      +11     
==========================================
+ Hits        10416    10426      +10     
- Misses         94       95       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from i03-device-manager to main December 1, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants