-
Notifications
You must be signed in to change notification settings - Fork 12
Converting MX Beamlines to device manager #1788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5c175c7 to
4a05f61
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1788 +/- ##
==========================================
- Coverage 99.12% 99.09% -0.03%
==========================================
Files 283 283
Lines 10736 10745 +9
==========================================
+ Hits 10642 10648 +6
- Misses 94 97 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f65166e to
662aa54
Compare
f98b994 to
9bfbbc4
Compare
…amondLightSource/dodal into 1765-Convert_MX_to_new_device_manager
| """ | ||
| return OAVToRedisForwarder( | ||
| f"{PREFIX.beamline_prefix}-DI-OAV-01:", | ||
| oav_roi=oav(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be updated to pass oav in to avoid multiple instances
…amondLightSource/dodal into 1765-Convert_MX_to_new_device_manager
Fixes #1765
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}