Accessibility issues resolved #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssibiblity in dark mode
…rk theme dark colour made darker to pass accessibility with white text. old diamond theme kept. breadcrumbs and user components updated to use dark colouring
RhysMAdey
changed the title
akademy
requested changes
Nov 4, 2025
Member
akademy
left a comment
akademy
left a comment
There was a problem hiding this comment.
Looks good, just a few comments.
…wrap all content inside DataBox and not each databox
akademy
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavBar/Footer/Breadcrumb/User button/ScrollImage/Header/JSON Forms accessibility issues resolved
DiamindTheme changed so that:
dark.primary.mainis the same aslight.primary.maindark.primary.darkhas been changed to be darker and pass accessibility once white text combinedlogos.normal.srcnow uses the light diamond logo as the header is darker it looks betterBreadcrumb comp now uses
dark.primary.darkand passes accessibility.User comp now uses
dark.primary.darkand passes accessibility.role="banner" removed from NavBar as when places in
tag in apps there are duplicate banner roles causing issues.tag needed in DataBox comp for JSON form erros.
Once integrated into application it should look like:
Light mode:
