-
Notifications
You must be signed in to change notification settings - Fork 1
Made changes to match prefixes with wildcards #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 81.89% 81.18% -0.72%
==========================================
Files 7 7
Lines 580 590 +10
==========================================
+ Hits 475 479 +4
- Misses 105 111 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Have tested this again and seems to be working/reporting sensible logs. |
niamhdougan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-opening so we can account for more use cases like
prefix: *DCM*
or
prefix: MY-PREFIX:[X, Y, Z]
|
Should work with those now |
e0bbec8 to
b3d61ab
Compare
|
I rebased this on main and fixed the merge conflict |
b3d61ab to
52ca422
Compare
52ca422 to
107ed38
Compare
107ed38 to
8e78e11
Compare
This commit adds the ability for users to add wildcards in the prefixes, needs extensive testing