Massive update #24
Merged
Massive update #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSCode was complaining about gradle versions, etc. These changes seem to remove them.
This handles device names and patterns.
It returns the GraphQL handles in a consistent way.
Change the language to be third person.
This code tried to use the build context after an awaited call. I applied the suggested fix.
If you dragged a row to the last row, it would go back to where it was. This commit fixes the bug.
There was a lot of cut-n-paste to handle the `_selectedSheet`. This commit adds a setter and getter which try to keep the `_selectSheet` and `_sheets` fields in sync.
This module defines a type reported by DrMem. It should be in the module that contains the DrMem provider widget.
The `if-case` test was looking for too much type matching in the `nodes` parameter. This commit just makes it a list of `Object`s. The `.fromJson()` method will do the final validation of the type.
Now we log when there's an error instead of printing the entire state. The console was getting a huge amount of text as I added more and more sheets.
When we switched to using `Device` objects instead of Strings, there was an instance where the name was an empty string. The `Device` class doesn't allow this. This commit makes the device field nullable.
The "default node" star is now it's own widget. Since this state tracks the default node in the configuration, every row in the node list would redraw if a new node was selected as the default. Now only the stars redraw themselves.
This also moves the error reporting to a new module.
When the screen is wide, use a `NavigationRail`. Otherwise use a `BottomNavigationBar`.
This commit adds a client ID to the App state and allows it to be changed in the settings page.
This was
linked to
issues
Nov 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the result of a year's worth of effort (with gaps of low effort, too.)
This pull request contains code that should satisfy issues #6, #13, #16, and #22. Before merging, all these issues should be resolved.