Skip to content

not only for mobile #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvciekzvbek wants to merge 1 commit into
base: dreamlab-develop
Choose a base branch
from
Open

not only for mobile #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/components/popup/details/vendors/vendors.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,20 +73,20 @@ div.vendors {
text-align: center;
min-width: 60px;

@media @smartphone {
min-width: 65px;
span:first-child {
Copy link

@skoklowski skoklowski Jun 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that real problem is that is not allowed to put span tag directly inside tr. Only td and th is allowed there. We should fix this issue instead doing hacks in CSS because such HTML is invalid so we never know when it will stop working in some future browsers version.

display: inline-block;
width: 100%;
}

& > th {
span:first-child {
display: inline-block;
width: 100%;
}
}

& > th {
span:first-child {
display: inline-block;
width: 100%;
}
}
@media @smartphone {
min-width: 65px;
}
}
table {
Expand Down