Skip to content

WIP: Feat/5 ios sdk upgrade #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrekovac wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Feat/5 ios sdk upgrade #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4acc7c
Switch from deprecated `login` function to `identify`
andrekovac Jan 15, 2021
8fcba13
Fix two podspec validation errors
andrekovac Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/HelpscoutBeacon.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ - (dispatch_queue_t)methodQueue

// Store beaconUser locally
beaconUser = user;
[HSBeacon login:user];
[HSBeacon identify:user];
}

RCT_EXPORT_METHOD(addAttributeWithKey:(NSString *)key valueParameter:(NSString *)value)
Expand Down
4 changes: 2 additions & 2 deletions react-native-helpscout-beacon.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ Pod::Spec.new do |s|
s.version = package["version"]
s.summary = package["description"]
s.description = <<-DESC
react-native-helpscout-beacon
React Native module for the Help Scout Beacon SDK
DESC
s.homepage = "https://github.com/Driversnote-Dev/react-native-helpscout-beacon"
s.license = "MIT"
# s.license = { :type => "MIT", :file => "FILE_LICENSE" }
s.authors = { "Driversnote.com" => "ja@driversnote.com" }
s.platforms = { :ios => "9.0" }
s.source = { :git => "https://github.com/Driversnote-Dev/react-native-helpscout-beacon.git", :tag => "master" }
s.source = { :git => "https://github.com/Driversnote-Dev/react-native-helpscout-beacon.git", :tag => package["version"] }

s.source_files = "ios/**/*.{h,m,swift}"
s.requires_arc = true
Expand Down