Skip to content

UI bug fix #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cow258 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UI bug fix #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 13 additions & 16 deletions src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { AnimatePresence, motion } from 'framer-motion';
import { AnimatePresence } from 'framer-motion';
import { useEffect, useState } from 'react';
import './App.css';
import Filter from './Components/Filter';
Expand All @@ -8,7 +8,7 @@ function App() {
const [popular, setPopular] = useState([]);
const [filtered, setFiltered] = useState([]);
const [activeGenre, setActiveGenre] = useState(0);

const fetchPopular = async () => {
// i haven't used .env file because its free api key
const response = await fetch("https://api.themoviedb.org/3/movie/popular?api_key=1af8f5a0dac921ed793eaf9b1a89b23e&language=en-US&page=1");
Expand All @@ -23,25 +23,22 @@ function App() {

return (
<div className="App">
<Filter
popular={popular}
setFiltered={setFiltered}
activeGenre={activeGenre}
setActiveGenre={setActiveGenre}
/>
<motion.div
layout
className="popular-movies"
>
<Filter
popular={popular}
setFiltered={setFiltered}
activeGenre={activeGenre}
setActiveGenre={setActiveGenre}
/>
<div className="popular-movies">
<AnimatePresence>
{filtered.map(movie => (
<Movie
key={movie.id}
movie = {movie}
<Movie
key={movie.id}
movie={movie}
/>
))}
</AnimatePresence>
</motion.div>
</div>
</div>
);
}
Expand Down
4 changes: 2 additions & 2 deletions src/Components/Movie.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import { motion } from "framer-motion"

const Movie = ({ movie }) => {
return (
<motion.div
layout
<motion.div
layout="position"
animate={{ opacity: 1 }}
initial={{ opacity: 0 }}
exit={{ opacity: 0 }}
Expand Down