-
Notifications
You must be signed in to change notification settings - Fork 56
Add back monitor tutorials #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
check-in the raw MD file
remove old syntax
Editorial and peer review
|
pls merge it to dev |
| @@ -0,0 +1,81 @@ | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this whole file qualifies as a "how-to". Starting from "Running Nodeos" the file contains concepts and explainers that act as prerequisites to the actual how-to in docs/03_tutorials/monitoring-with-state-history-plugin.md. Moreover, I copied some sections from this file to the nodeos implementation section in the nodeos manual. We need to discuss where to place this content going forward keeping in mind that we need a clear separation between explainers, how-tos, and tutorials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we need to discuss which part to move around, take off and update. Now it is just at the formatting stage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would adding the following content title makes sense? This is to remove the "how-to" idea and make it more generic.
content_title: Monitor State History
link_text: Monitor State History
| [block:callout] | ||
| { | ||
| "type": "warning", | ||
| "body": "The resources listed below are developed, offered, and maintained by third-parties and not by block.one. Providing information, material, or commentaries about such third-party resources does not mean we endorse or recommend any of these resources. We are not responsible, and disclaim any responsibility or liability, for your use of or reliance on any of these resources. Third-party resources may be updated, changed or terminated at any time, so the information below may be out of date or inaccurate. USAGE AND RELIANCE IS ENTIRELY AT YOUR OWN RISK." | ||
| } | ||
| [/block] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convert to proper callout
| [block:callout] | ||
| { | ||
| "type": "warning", | ||
| "body": "These are in no particular order. Descriptions of each tool have been provided by the tool authors." | ||
| } | ||
| [/block] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convert to proper callout
| [block:api-header] | ||
| { | ||
| "title": "Elastic Search Plugin" | ||
| } | ||
| [/block] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convert to proper markdown element
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [block:api-header] | ||
| { | ||
| "title": "Kafka Plugin" | ||
| } | ||
| [/block] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convert to proper markdown element (fix the rest below)
Github rebase to |
I don't follow entirely your message here... |
|
Hi guys, @bobgt is working on markdown syntax but thanks for taking time to review |
|
I think y’all need a live conversation regarding this issue. Set up a meeting to discuss your concerns and come to a conclusion. Let’s support each other. Let me know what you conclude. |
|
@iamveritas no need to throw that strawman. If you look closer, the target branch now reads |
Apply markdown syntax to 3rd party monitoring
bobgt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments.
|
given the some components change, this probably requires more rewritten |
|
I think this is good to merge for now. |
|
Hey @lparisc: Are you okay with the updates made to this PR? Any more changes/suggestions from your side before we merge it? |
|
@bobgt I'll check it first thing Monday |
|
|
||
| [[info]] | ||
| | | ||
| This article assumes you have installed the EOSIO software and are familiar with using the EOSIO nodeos and cleos tools. It is recommended that you have completed [the Getting Started section](https://developers.eos.io/eosio-home/docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update some links:
https://developers.eos.io/eosio-home/docs --> https://developers.eos.io/welcome/latest/index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing, I'm mot sure merging this content is the best course of action at the moment for the following reasons:
- The content related to the state history plugin needs updating.
- Most if not all of the links to various nodeos sections are broken.
- The way state will be monitored in EOSIO 2.1 will change anyway with rodeos.
Let me delve a bit more on this and get back with some options.
No description provided.