Extended non-LTE CO2 cooling parameterization #1457
Conversation
new file: src/physics/waccm/nlte_extco2.F90 modified: bld/configure modified: bld/namelist_files/namelist_definition.xml modified: src/physics/waccm/nlte_lw.F90 modified: src/physics/waccm/radheat.F90
modified: bld/config_files/definition.xml modified: bld/configure modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_ctem/shell_commands modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_ctem/user_nl_cam modified: src/physics/waccm/nlte_extco2.F90 modified: src/physics/waccm/radheat.F90
| real(r8), intent(in) :: co2_mw ! CO2 molecular weight | ||
| real(r8), intent(in) :: n2_mw ! N2 molecular weight | ||
|
|
||
| #ifdef EXT_CO2_COOL |
There was a problem hiding this comment.
I'm wondering about why you felt the need to encapsulate this code within a #ifdef. We try to avoid using these directives and backtracing this particular routine, it is only called when nlte_use_extco2 is true. I believe this #ifdef is not needed. I've not analyzed the other #ifdef directives, but I would suggest there might also might be others that are not needed. If all can be removed, please remove the definition from configure as well.
There was a problem hiding this comment.
The external code ext_co2_cooling code does not compile with NAG compiler.
There was a problem hiding this comment.
With that in mind, does it make sense to only #ifdef the calls and the use statements (keep it contained around the code which only needed to not compiled)?
| <ncdata hgrid="ne16np4" nlev="126" waccmx="1" aquaplanet="1" >atm/waccm/ic/waccmx_aqua_ne16np4_126L_c191108.nc</ncdata> | ||
| <ncdata hgrid="ne16np4" nlev="126" waccmx="1" aquaplanet="1" ionosphere="none">atm/waccm/ic/waccmx4_neutral_aquap_ne16np4_126lev_c200827.nc</ncdata> | ||
| <ncdata hgrid="ne16np4" nlev="130" waccmx="1" >atm/waccm/ic/waccmx_ne16pg3_L130_c250318.nc</ncdata> | ||
| <ncdata hgrid="ne16np4" nlev="130" waccmx="1" >atm/waccm/ic/FX2000_ne16pg3_spinup01.cam.i.0002-01-01_c251215.nc</ncdata> |
There was a problem hiding this comment.
Has this file been "rimport"ed?
|
|
||
| <entry id="nlte_use_extco2" type="logical" category="waccm_phys" | ||
| group="radheat_nl" valid_values="" > | ||
| If TRUE, then use the extended CO2 scheme of Lopez-Puertas et al. 2024 as an alernative method of computing non-LTE |
There was a problem hiding this comment.
Since this is a comment which will show up on a web page, would it be appropriate to include the DOI here also?
2 participants
Closes #1358