Skip to content

Conversation

@andcaspe
Copy link

@andcaspe andcaspe commented Mar 8, 2025

Describe your changes

I have updated all occurrences where particle.max_occurs > 1 was used directly to instead use the is_array property. This ensures consistency across the codebase and improves maintainability by centralizing the logic for determining whether a data type is an array. This change also facilitates compatibility with OpenV2G (I was trying to update the parser in order to make the autogenerated code compatible with OpenV2G), which has a different interpretation of unbounded data types with a max occurrence of 1. By using is_array consistently, any future modifications to array detection criteria can be easily applied throughout the project.

Issue ticket number and link

Issue number 107

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Andreu Castillo added 3 commits March 8, 2025 18:03
Signed-off-by: Andreu Castillo <castillo.andreu97@gmail.com>
Signed-off-by: Andreu Castillo <castillo.andreu97@gmail.com>
Signed-off-by: Andreu Castillo <castillo.andreu97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants