Skip to content

Conversation

@EatSleepProgramRepeat
Copy link
Owner

now we warn people when we use cdstubs

@EatSleepProgramRepeat EatSleepProgramRepeat linked an issue Apr 21, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a warning for users when they select "CDStub" as a search type while also changing the default table model parameter.

  • Changed the default table model parameter from "CDStub" to "Release".
  • Reordered the search type options and added an action listener to warn users about CDStub usage.
Files not reviewed (1)
  • src/main/resources/version.properties: Language not supported
Comments suppressed due to low confidence (1)

src/main/java/com/CDPrintable/ProgramWindow.java:160

  • [nitpick] The warning message is clear; however, consider if warning the user without preventing the search might still lead to confusion. It may be beneficial to integrate additional UI feedback or update the table model dynamically based on the selection.
searchTypeComboBox.addActionListener(_ -> { ... if (searchTypeComboBox.getSelectedItem() != null && searchTypeComboBox.getSelectedItem().equals("CDStub")) { JOptionPane.showMessageDialog(null, "CDStubs do not have track numbers. Because of this, they will all be shown as track 0.", "Warning", JOptionPane.WARNING_MESSAGE); } ... } );

@EatSleepProgramRepeat EatSleepProgramRepeat merged commit 8f79407 into main Apr 21, 2025
1 check passed
@EatSleepProgramRepeat EatSleepProgramRepeat deleted the 73-cdstub-searches-dont-have-track-numbers branch April 21, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CDStub Searches don't have track numbers

2 participants