-
-
Notifications
You must be signed in to change notification settings - Fork 455
Helloradio 20250309 V5 #6085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Helloradio 20250309 V5 #6085
Conversation
1.Redefine the V14 toggle switch 2.Increase voltage measurement for V12 and V14 3.Add voice recognition chip drivers to V14 and V16 4.Add gyroscope chip driver to V14 and V16 5.Add self check function for the startup GIMBAL RGB 6.Place the common driver in the target folder/targets/common 7.Correct the macro definition of V12
2.Increase voltage measurement for V12 and V14 3.Add voice recognition chip drivers to V14 and V16 4.Add gyroscope chip driver to V14 and V16 5.Add self check function for the startup GIMBAL RGB 6.Place the common driver in the target folder/targets/common 7.Correct the macro definition of V12
There are some minor differences, but it should still work as is, or will need the I2C_Bus_1 lines updated for V16
2.V14 needs to use 660 to retrieve RTC data, and the display will be correct
| #if defined(CI1302_SENSOR) | ||
| .name = "Voice", | ||
| #else | ||
| .name = "AUX1", | ||
| #endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously, you don't want this serial port to be configurable. This means that you want to define it directly in a board specific driver instead of adding it to generic configurable serial ports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to demonstrate my special functional characteristics, so it seems that I cannot implement these functions in this way
| #if defined(CI1302_SENSOR) | ||
| processVoiceInput(); | ||
| processUpdataInput(); | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a FreeRTOS timer instead, started from your own board drivers.
| #if defined(GYRO_SENSOR) | ||
| #include "imu_42627.h" | ||
| #endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed here?
| #if defined(HR_GIMBAL_RGB) | ||
| splashStartTime=get_tmr10ms(); | ||
| if(SPLASH_TIMEOUT<(6000/10)) //time expand GIMBAL_RGB init loop | ||
| splashStartTime+=6000/10; | ||
| else | ||
| splashStartTime += SPLASH_TIMEOUT; | ||
| #else | ||
| splashStartTime += SPLASH_TIMEOUT; | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should really not be here. What are you trying to achieve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to demonstrate my special functional characteristics, so it seems that I cannot implement these functions in this way
| #if defined(HR_GIMBAL_RGB) | ||
| rbgInitLoop(1); | ||
| ws2812update(); | ||
| #endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should really not be here. If you want to implement some gimmick for your particular radio, this will have to be done differently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file does not contain anything generic enough to be in this directory. Besides, this code is definitely not up to any reasonable coding standards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just can't customize and showcase my own special features independently, so I have to delete them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as gimbal_rgb.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is definitely not up to any reasonable coding standards. Besides, it does not even mention which chip this is for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I create a completely private folder in the 'Target' folder to manage my feature files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as imu4.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is definitely not up to any reasonable coding standards. Besides, which chip or chip family is this even covering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that I should temporarily give up these features and debug the general functions first. Now these are a big challenge for me
Fixes #
Clean up redundant code and eliminate code compilation warnings.
Summary of changes:
1.Redefine the V14 toggle switch
2.Increase voltage measurement for V12 and V14
3.Add voice recognition chip drivers to V14 and V16
4.Add gyroscope chip driver to V14 and V16
5.Add self check function for the startup GIMBAL RGB
6.Place the common driver in the target folder/targets/common
7.Correct the macro definition of V12
8.Revise the definition of V16 RTC voltage conversion value