-
-
Notifications
You must be signed in to change notification settings - Fork 455
SVG & PNG for color LCD radio - change & clean up #6781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JimB40
wants to merge
11
commits into
EdgeTX:main
Choose a base branch
from
JimB40:radio-gfx-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
3 tasks
95d6362 to
17d08b5
Compare
1. changed img-src files names & folder structure - files follows naming <bmp_|mask_><type_><name>.svg scheme that follows Figma UI Design scheme - bmp_ & mask_ prefix defines PNG type - no subfolders to simplify PNG generation & review - all SVG vector sources simplified end re-exported to img-src 2. Replaced PNG - PNGs now have new names - unused PNGs are removed - conversion done using rsvg-convert for smaller size 3. Modified CMakeList.txt - simplified 4. Modified *.cpp - all *.cpp with *.lbm references are updated to reflect naming change - _BuiltinIcon names left untouched to avoid conflicts (lots of changes in code) 5. tools script to convert SVG to PNG - changed name to convert-gfx - added --resvg param to force using resvg insted of rsvg-convert (testing)
*.lbm names fix
1. add missing Favourite PNGs for EdgeTX#6753 2. added --update parameter to script - CSV now keeps track of SVG modification date - running ./convert-gfx.sh --make all --update will only re-genarate PNGs for SVG s with newer modification date that the one in CSV
318205f to
dca4592
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR
Summary of changes:
Other PRs @pfeerick