Skip to content

Conversation

@Elena-Nam
Copy link
Owner

added gifts page and media queries, created session storage, worked on styles

@Elena-Nam
Copy link
Owner Author

Hello, Lee. I tried to store the key but didn't have enough time. Also I could separate drinks, unfortunately, Coffee API isn't working today.

Copy link

@Lee-Rice Lee-Rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Elena,
Here are my comments on your open-api project. I'll also send them through Slack.

  • Great job overall. This is really cool project and must have been a ton of work. The only real issue I noticed was that the Close button on the last page (under the dog's picture) throws an error closeForm is not defined.
  • No worries about the API. It looks like you're catching and logging error messages. It wouldn't be a bad idea to let the user know an error occurred as well though, just so they aren't confused why no drinks are showing.
  • Outstanding work on the README file. Especially explaining to the user how to replace the API key with one of their own.
  • I really like how you added the "Meet" box that pops up with information about each dog.
  • On some pages, the Top button covers the Next button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants