Skip to content

Conversation

@DimaVartanian
Copy link

Thanks for making this cool library! I'm messing around with RatScanner and saw this. Made 2 changes that seem like they should be all around improvements

  1. Separate count and found in raid count for quest items to prevent overwriting in case an item has separate FiR and not FiR requirements. No items currently seem to have both a fir and non-fir requirement, but seems like this can't hurt rather than using a flag which can overwrite state.
  2. Replace both lists with dictionaries. This removes the nested lookup loops when building the files and allows you to look up items in constant time.

Note: old pull request can be ignored. Ended up with some merge issues so just recreated.

DimaVartanian and others added 2 commits March 21, 2021 20:05
1. Separate count and found in raid count for quest items to prevent overwriting in case an item has separate FiR and not FiR requirements. No items currently seem to have both a fir and non-fir requirement, but seems like this can't hurt rather than using a flag which can overwrite state.
2. Replace both lists with dictionaries. This removes the nested lookup loops when building the files and allows you to look up items in constant time.
@DimaVartanian
Copy link
Author

About the second commit: I noticed that some things on the wiki didn't have consistent casing, so it's pretty much a crapshoot. "antique teapot" is one example that isn't correct, so looking up the name based on how it actually appears in the game doesn't work. Casting to lower case seems safer since you can always do the same with what you're looking it up with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant