Improve compatibility with other plugins by not cancelling chat events #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. (e.g. DiscordSRV)
Owner
|
But why doesn't DiscordSRV use ignoreCancelled? |
Owner
|
In the future i will make a DiscordSRV integration but only on DiscordSRV 3.0 (Ascension) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, RedisChat cancelled AsyncPlayerChatEvent directly, which prevents plugins like DiscordSRV from seeing the message.
This PR replaces
event.setCancelled(true)withevent.getRecipients().clear(), which suppresses local message broadcasting but still allows observers like DiscordSRV to receive the event.This improves cross-plugin compatibility, especially for DiscordSRV integration, while preserving RedisChat's control over chat routing.
Tested working with DiscordSRV. No known regressions.