-
-
Notifications
You must be signed in to change notification settings - Fork 13
Add MiniGrid overview page and update map routes. #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add MiniGrid overview page and update map routes. #1192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for your contribution 🙏 . Dropping a couple of comments here!
- You can use Github Pull Requests keywords to automatically link this PR to an issue: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests For example
Resolves: #130in the description of the PR.
| <!-- 03949af4-ca3a-4720-b787-615eb4092417 5ecdb199-cae5-46c6-91d9-1d52781cedc3 --> | ||
| # Restructure Mini-Grid Routes to Match Agents Pattern | ||
|
|
||
| ## Overview | ||
|
|
||
| Restructure Mini-Grid routes to match the Agents pattern with a top-level sidebar item and expandable submenu, moving from `/dashboards/mini-grid` to `/mini-grids`. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add generated files like this one to the repo.
docs/usage-guide/sms.md
Outdated
|
|
||
|  | ||
|
|
||
| ### Step 4: Register SMS Delivery Callback URL | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow you have changes in sms.md but your changes are unrelated right? It's causing merge conflicts. Could you resolve these?
Brief summary of the change made
Resolves: #130
#Created MiniGridDashboard.vue component — similar to AgentDashboard.vue:
Metrics boxes: Total Mini-Grids, Total Clusters, Total Cities, Total Agents
Searchable table listing all mini-grids
Columns: Name, Cluster, Created At, Cities, Agents
Clickable rows navigate to the detail page
#Refresh button to reload data
#Updated pages/Dashboard/MiniGrid/index.vue:
#Replaced the redirect logic with the new MiniGridDashboard component which matches the Agents overview page structure.
#Added translation keys to en.json:
miniGridDashboard: "Mini-Grid Overview"
miniGridList: "Mini-Grid List"
totalMiniGrids: "Total Mini-Grids"
totalClusters: "Total Clusters"
totalCities: "Total Cities"
#The component handles missing API data (e.g., cities_count, agents_count, cluster) and displays "-" or 0 when unavailable. The overview page now shows a list of mini-grids in a table format, matching the Agents overview page pattern, instead of using a dropdown menu.
Are there any other side effects of this change that we should be aware of?
Describe how you tested your changes?
-I used es-linters to test it out for any errors , and first run the setup locally on my machine before pushing the code to the remote repo .
Pull Request checklist
Please confirm you have completed any of the necessary steps below.