Skip to content

Fixed issue with Parametric commands failing due to CommandArgs not being in namespace. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
me4502 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed issue with Parametric commands failing due to CommandArgs not being in namespace. #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions intake/src/main/java/com/sk89q/intake/parametric/AbstractParametricCallable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ public final boolean call(String stringArguments, Namespace namespace, List<Stri
String[] split = CommandContext.split(calledCommand + " " + stringArguments);
CommandContext context = new CommandContext(split, parser.getValueFlags(), false, namespace);
final CommandArgs commandArgs = Arguments.viewOf(context);
namespace.put(CommandArgs.class, commandArgs);
List<InvokeHandler> handlers = new ArrayList<InvokeHandler>();

// Provide help if -? is specified
Expand Down Expand Up @@ -204,8 +205,6 @@ public final boolean call(String stringArguments, Namespace namespace, List<Stri
return true; // Abort early
}

namespace.put(CommandArgs.class, commandArgs);

// invoke
try {
builder.getCommandExecutor().submit(new Callable<Object>() {
Expand Down