Skip to content

Conversation

@Tacha-S
Copy link
Contributor

@Tacha-S Tacha-S commented Mar 27, 2025

I added the recurse-submodules option to automatically set up submodules when cloning.

I tested this behavior using the following .repos file.

repositories:
  xarm_ros2:
    type: git
    url: https://github.com/xArm-Developer/xarm_ros2.git
    version: jazzy

rv import -i test.repos /tmp/example -r -s

with shallow option
rv import -i test.repos /tmp/example -r -s -l

@ErickKramer
Copy link
Owner

Thanks for the contribution, would you mind rebasing your branch onto main to address the merge conflicts?

@Tacha-S Tacha-S force-pushed the feature/setup-submodule branch from 6ab7960 to 3e740cc Compare March 27, 2025 23:55
@Tacha-S
Copy link
Contributor Author

Tacha-S commented Mar 27, 2025

I’ve rebased the branch onto main.

@ErickKramer
Copy link
Owner

Thanks for that. I checked the changes, and since you are modifying the GitClone function, it would makes sense to have a test where the submodule update functionality is validated. Could you take care of that?

@Tacha-S
Copy link
Contributor Author

Tacha-S commented Mar 28, 2025

I added some test cases.
Please let me know if there’s anything missing.

@ErickKramer ErickKramer merged commit ec752bf into ErickKramer:main Mar 28, 2025
3 checks passed
@ErickKramer
Copy link
Owner

Thanks for addressing the tests. I checked and it worked out fine 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support submodule setup during rv import

2 participants