Skip to content

Fix epm download command exit code if no package can be fetched. #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eteryear wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Fix epm download command exit code if no package can be fetched. #554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bin/epm-download
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,12 @@ startwith_inlist()
return 1
}

# Non-local variable because `local` builtin returns exit code "0" even if command substitution fails.
epm_download_alt__result_url="$(__epm_alt_get_package_url install --reinstall "$@")" || return

# old systems ignore reinstall ?
local url
for url in $(__epm_alt_get_package_url install --reinstall "$@") ; do
for url in $epm_download_alt__result_url ; do
startwith_inlist "$(basename "$url")" "$@" || continue
[ -n "$print_url" ] && echo "$url" && continue
# TODO: download together
Expand Down