-
Notifications
You must be signed in to change notification settings - Fork 2
Story title and summary added to editor and player #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Refactored the ImageUpload component to support drag-and-drop image uploads in addition to file selection. Added visual feedback for drag state and improved user interaction by allowing both clicking and dropping files to trigger uploads.
Enhanced drag-and-drop handling by tracking nested drag events with a counter, ensuring accurate drag state. Added file type checks, improved drop zone click behavior, and updated styles for better user feedback and accessibility.
Included the story summary in the outputs of getStoryMermaid and getStoryGraph queries. Updated StoryGraphViewer to display the summary below the story title if available.
Improved the StoryEditor header to display the story title and summary, and reorganized controls for better clarity. Refactored StoryGraphViewer to combine stats and zoom controls into a single row, streamlined the layout, and removed redundant code comments for cleaner component structure.
Adjusted conditional styling for AIAssistant header padding. Fixed duplicate rendering of AIAssistant in StoryEditor. Improved spacing and grouping of stats in StoryGraphViewer for better visual clarity.
Introduces an optional thumbClassName prop to ScrollArea and ScrollBar components for custom scrollbar thumb styling. Applies a purple thumb style in StoryEditor for improved UI customization.
Changed color scheme from purple to orange in AIAssistant component and updated paths preview section in StoryEditor to use purple accents. Also added effect to reset paths preview expansion when switching nodes for improved UX.
The outgoing paths header in StoryEditor now applies margin, padding, and border styles only when paths are expanded, improving UI responsiveness and clarity.
Reorganized the outgoing choices UI to introduce a clearer section header and improved structure. The 'Outgoing Choices' label is now always visible, and the paths preview is conditionally rendered within this section, enhancing clarity and user experience.
Adds a left margin to the sidebar toggle button when the sidebar is collapsed and reduces the MoveRight icon size for better visual alignment.
Introduces mutations and UI controls to allow users to edit the story title and summary directly from the StoryEditor component. Updates include new state management for editing, save/cancel actions, and integration with backend mutations for persisting changes.
Changed the button text from 'Edit' to 'Edit Heading' and 'Edit Summary' for better clarity in the StoryEditor component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the ability to edit story titles and summaries directly in both the story editor and player interfaces. The changes include new backend mutations for updating story metadata, UI enhancements for inline editing, and several supporting UI improvements including drag-and-drop image upload, AI assistant color scheme changes, and graph viewer layout refinements.
- Added inline editing capabilities for story titles and summaries with save/cancel functionality
- Implemented drag-and-drop image upload with visual feedback and improved UX
- Restructured the graph viewer layout to consolidate controls and improve information density
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| StoryForge/convex/ui.ts | Added updateStoryTitle and updateStorySummary mutations, extended getStoryGraph to return title and summary |
| StoryForge/convex/queries/visualization.ts | Added summary field to visualization query response |
| StoryForge/src/components/ui/story/StoryEditor.tsx | Implemented inline editing UI for story title and summary with edit/save/cancel buttons, reorganized header layout |
| StoryForge/src/components/ui/story/StoryGraphViewer.tsx | Consolidated zoom controls and stats into a single row, improved layout spacing |
| StoryForge/src/components/ui/story/AIAssistant.tsx | Changed color scheme from purple to orange theme |
| StoryForge/src/components/ui/story/ImageUpload.tsx | Added drag-and-drop functionality with visual feedback, refactored file validation into separate function |
| StoryForge/src/components/ui/scroll-area.tsx | Added support for custom scrollbar thumb styling via thumbClassName prop |
| StoryForge/src/components/ui/storyplay.tsx | Minor adjustment to sidebar toggle button icon size and margin |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added owner/admin permission checks to story title and summary mutations to prevent unauthorized updates. Refactored ImageUpload to simplify click/drag handling and improved UI feedback. Updated StoryEditor to always exit edit mode after attempting to update title or summary, regardless of success or failure.
Add drag-and-drop support to ImageUpload component
The merge-base changed after approval.
The merge-base changed after approval.
Included the story summary in the outputs of getStoryMermaid and getStoryGraph queries. Updated StoryGraphViewer to display the summary below the story title if available.
Improved the StoryEditor header to display the story title and summary, and reorganized controls for better clarity. Refactored StoryGraphViewer to combine stats and zoom controls into a single row, streamlined the layout, and removed redundant code comments for cleaner component structure.
Adjusted conditional styling for AIAssistant header padding. Fixed duplicate rendering of AIAssistant in StoryEditor. Improved spacing and grouping of stats in StoryGraphViewer for better visual clarity.
Introduces an optional thumbClassName prop to ScrollArea and ScrollBar components for custom scrollbar thumb styling. Applies a purple thumb style in StoryEditor for improved UI customization.
Changed color scheme from purple to orange in AIAssistant component and updated paths preview section in StoryEditor to use purple accents. Also added effect to reset paths preview expansion when switching nodes for improved UX.
The outgoing paths header in StoryEditor now applies margin, padding, and border styles only when paths are expanded, improving UI responsiveness and clarity.
Reorganized the outgoing choices UI to introduce a clearer section header and improved structure. The 'Outgoing Choices' label is now always visible, and the paths preview is conditionally rendered within this section, enhancing clarity and user experience.
Adds a left margin to the sidebar toggle button when the sidebar is collapsed and reduces the MoveRight icon size for better visual alignment.
Introduces mutations and UI controls to allow users to edit the story title and summary directly from the StoryEditor component. Updates include new state management for editing, save/cancel actions, and integration with backend mutations for persisting changes.
Changed the button text from 'Edit' to 'Edit Heading' and 'Edit Summary' for better clarity in the StoryEditor component.
Added owner/admin permission checks to story title and summary mutations to prevent unauthorized updates. Refactored ImageUpload to simplify click/drag handling and improved UI feedback. Updated StoryEditor to always exit edit mode after attempting to update title or summary, regardless of success or failure.
…ttps://github.com/Etown-CS310/Story-Forge into story-title-and-summary-added-to-editor-and-player
No description provided.