[WIP] Apply code review comments from PR 257

[Copilot]

Successfully Addressed Code Review Comments for PR #257

✅ All Items Completed:

• Fix docstring inconsistency: Updated MaterialFingerprintAllAxes.get_similarity_matrix docstring to use "MaterialFingerprintAllAxes" instead of "MaterialFingerprint"
• Fix broken test assertion: Fixed test_rotate that was using .sort() incorrectly (returns None, making test always pass)
• Improve test coverage: Replaced misleading test with proper validation that rotation works correctly
• Add test for arbitrary rotations: Added test_rotate_arbitrary_angle to verify non-symmetric rotations
• Run full test suite: All 24 tests in affected modules pass
• Run linter: Code meets style requirements (1 pre-existing minor issue unrelated to changes)
• Security scan: CodeQL found 0 alerts

Summary of Changes:

1. Fixed Docstring (material_fingerprint_all_axes.py)

• Changed reference from incorrect "MaterialFingerprint" to correct "MaterialFingerprintAllAxes"
• This addresses review comment about class name inconsistency

2. Fixed Broken Test Assertions (test_tools_modify.py)

• Root Cause: Original test_rotate used .sort() which returns None, so it was comparing None == None (always True)
• Review Comment: "Critical: Test always passes due to .sort() returning None"
• Solution:
  • Removed parametrized test with misleading assertions
  • Created test_rotate() that properly validates rotation functionality (lattice unchanged, atom count preserved, valid Material returned)
  • Added test_rotate_arbitrary_angle() for non-symmetric rotations
• Note: The original test incorrectly assumed 180° rotations preserve sorted coordinates - they don't. The test was passing only due to the .sort() bug.

Test Results:

• 24 tests passed in affected modules (test_tools_analyze_basis.py, test_tools_analyze_lattice.py, test_tools_modify.py)
• 0 security alerts from CodeQL
• Linter clean (1 pre-existing warning in unrelated file)

Context - Items Already Completed in PR #257:

• Separated fingerprint classes into dedicated modules
• Created MaterialFingerprintAllAxes class
• Created MaterialLatticeSwapAnalyzer for detecting lattice swaps
• Removed rotate_cell parameter from rotate() function
• Fixed rotate to clone material instead of mutating

Security Summary

No vulnerabilities discovered. CodeQL analysis returned 0 alerts for Python code.

Original prompt

Apply the code review comments in this PR https://github.com/Exabyte-io/made/pull/257/files

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}