Feature/SOF-7766-3 Update: methods implementation for MIN NB to run #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| It provides common methods for managing units in both Workflow and Subworkflow classes. | ||
| """ | ||
|
|
||
| units: List["Unit"] |
tests/py/test_workflow.py
Outdated
| from mat3ra.ade.application import Application | ||
| from mat3ra.mode.method import Method | ||
| from mat3ra.mode.model import Model | ||
| from mat3ra.standata.workflows import WorkflowStandata |
Member
There was a problem hiding this comment.
Flowchart units managers should be tested
tests/py/test_unit.py
Outdated
| assert data["head"] is True | ||
|
|
||
|
|
||
| def test_add_context_to_relaxation_unit(): |
| self._add_to_list(self.units, unit, head, index) | ||
| self.set_units(self.set_next_links(self.set_units_head(self.units))) | ||
|
|
||
| # TODO: Consider removing setNextLinks and setUnitsHead calls when flowchart designer implemented. |
| - `add_target(target)` - Add target | ||
| - `remove_target(target)` - Remove target | ||
| - `has_feature(feature)` - Check feature exists | ||
| - `has_target(target)` - Check target exists |
Member
There was a problem hiding this comment.
Remove the functions that we don't have
| @@ -0,0 +1,87 @@ | |||
| # TODO: We need periodic_table.js equivalent in Python | |||
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
This meant to be changed in the task for Context Providers. This is just a comment to implement that
| then: str = Field(default="") | ||
| else_: str = Field(default="", alias="else") | ||
| input: list = Field(default_factory=list) | ||
| maxOccurrences: int = Field(default=1) |
Member
There was a problem hiding this comment.
We should get the default values from schema
|
|
||
|
|
||
| class DataFrameIOUnit(IOUnit): | ||
| subtype: str = Subtype.dataFrame |
| from mat3ra.utils.uuid import get_uuid | ||
|
|
||
|
|
||
| def generate_uuid() -> str: |
| return get_uuid() | ||
|
|
||
|
|
||
| def find_by_name_or_regex( |
|
|
||
| @classmethod | ||
| def from_subworkflow(cls, subworkflow: Subworkflow) -> "Workflow": | ||
| raise NotImplementedError |
Member
There was a problem hiding this comment.
Let's create a separate branch without all NotImplementedError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.