Skip to content

Conversation

@dmitrymihalev
Copy link
Contributor

PR checklist

  • I've written good commit message for all commits
  • I've split changes into separate commits where it's appropriate
  • I've added the description of function to documentation
  • I've updated project version in pyproject.toml
  • I'll make a release when PR is merged
  • I'll bump pybotx in bot-template

@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9219e2e) to head (bd10418).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #511   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          125       126    +1     
  Lines         4381      4417   +36     
=========================================
+ Hits          4381      4417   +36     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmitrymihalev dmitrymihalev force-pushed the feature/dm/create_thread_method branch from 7fb4baf to 8c898a0 Compare June 24, 2025 10:19
@dmitrymihalev dmitrymihalev self-assigned this Jun 24, 2025
@dmitrymihalev dmitrymihalev force-pushed the feature/dm/create_thread_method branch from 88feb15 to c7bd57b Compare June 25, 2025 13:45
@dmitrymihalev dmitrymihalev force-pushed the feature/dm/create_thread_method branch from c7bd57b to 7fe0eca Compare June 25, 2025 13:46
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thread_creation_setup стоит вынести в фикстуру
create_chat_succeed - тред же, а не чат
Ты покрыл кейс только с ThreadCreationError, в идеале надо проверить кейсы:

  • status = "error"
  • reason = None или отсутствует
  • error_data = {}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • thread_creation_setup - это создание мокнутого эндпоинта?
  • create_chat_suceed - понял, недоглядел
  • status="error" и пустой error_data ведь проверяются, не до конца понимаю, что необходимо добавить

@osovskiyalexandr osovskiyalexandr merged commit 8b7ebd6 into master Jul 31, 2025
9 checks passed
@osovskiyalexandr osovskiyalexandr deleted the feature/dm/create_thread_method branch July 31, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants