-
Notifications
You must be signed in to change notification settings - Fork 16
feat: Add method to create thread to Bot #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #511 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 125 126 +1
Lines 4381 4417 +36
=========================================
+ Hits 4381 4417 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7fb4baf to
8c898a0
Compare
88feb15 to
c7bd57b
Compare
c7bd57b to
7fe0eca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thread_creation_setup стоит вынести в фикстуру
create_chat_succeed - тред же, а не чат
Ты покрыл кейс только с ThreadCreationError, в идеале надо проверить кейсы:
- status = "error"
- reason = None или отсутствует
- error_data = {}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thread_creation_setup- это создание мокнутого эндпоинта?create_chat_suceed- понял, недогляделstatus="error"и пустойerror_dataведь проверяются, не до конца понимаю, что необходимо добавить
PR checklist
pyproject.tomlpybotxinbot-template