Code Improvements #532
Code Improvements #532
Conversation
Modified code to make sure we get correct parameters when changing settings from the WebUI.
|
This is a minor fix for a scenario I saw yesterday while testing connmon, but I was unable to reproduce it at will, even though I can duplicate it easily with some made-up test files. Essentially, sometimes when diff'ing the configuration file looking for modified settings from the WebUI, the diff results would show more than just the modified lines, so the code handling a setting change was being triggered for a "change" that actually didn't happen. AFAICT, in the case of MerlinAU, this issue wouldn't cause a malfunction or an error, but I didn't run all the possible scenarios, so I decided to fix it anyway since that's the "right thing to do." 😉 |
|
Approved! Great catch! But always better to be safe than sorry, I appreciate the due-diligence! |
|
Hey, bud!! I hope you've been enjoying your new place since you guys got back from vacation!!! I just read that the latest Asuswrt-Merlin 3006.102.6 has been issued today, so I'm wondering if this would be a good time to also make the latest MerlinAU production release 1.5.7 version available as well. This would allow the latest changes in the 'develop' branch to get more mileage with real users. Just a thought!! 😉 Have a good evening, bud!! I'm getting ready to have an early dinner and take the rest of the week off for the Thanksgiving Holiday here in the US. |
Still working on getting the coax cable fixed in the walls of my new house (I think I told you about this?) Anyways it's more complicated and a bit of a mess as I continue to dig in. I found the start of the coax for the home that enters by the basement but one of the previous owners cut it!!!! I have no idea why you would physically cut the coax cable to the house, now I'm waiting for a crimping / splicing kit from Amazon to try and repair the coax cable. My backup is just run a new wire, it wouldn't fix every room, but it would get the rooms I care about back online to run a new coax wire.
I'm not against doing a release, but just so your aware at this point I've been unable to recreate the issue with the existing production version of MerlinAU. So I can't say for sure if we resolved that users issue, but we can deploy it for more testing with the users and maybe additional logging / information if it happens again (such as your email notifications)
I hope you enjoy the Holiday! Sorry for being quiet but I've been catching up at work after taking 3 weeks off for the move and my vacation, and I'm now the lead at work for all remote access solutions (VPN and Citrix) as my trainer and partner has moved on to other duties as the GoC shrinks. (due to cost cutting...) Plus my director is telling me I'm still over on the maximum carry-over of 262.5 hours so I still need to take another week off! (Non-optional) But I need to prep 2 new releases! All that to say it's been non-stop between work and the home. |
Ah, yes, the trials and tribulations of home ownership!! There's always something to fix, paint, patch, or renovate, according to the wife, LOL!!! So the "honey-do" list never gets finished!! In our last renovation done on the house, I put shielded CAT6a Ethernet cabling going to all our rooms to avoid any issues with WiFi in certain places. If you can, I'd highly recommend putting Ethernet cables instead of coax - perhaps not now, but in the near future.
Yeah, I was not able to recreate it either. I believe it's a timing factor that would cause the issue with the USB drive getting "busy" for a few minutes at just the right moment when attempting to unmount it. In any case, the latest changes should hopefully provide further clues if it happens again.
Yeah, I get it. That always happens to me when I come back from vacation as well, trying to catch up with all that happened while I was gone. And I was busy myself with work as we're getting ready for the last major release of this year due on December 10th. |
It's coax already in the home so I'm just trying to restore the coax to a working state, or a semi-working state, if I ever open up dry wall though I'll do Ethernet / Cat6 RJ45 for sure. Even the new cable run would only go through the unfinished part of the basement so for now I'm doing all the work without opening dry wall.
I'll prep a new release and should have it ready by the time your back from dinner! |
|
Done! See PR: #535 ready and out the door! |
|
I’ve solved the network issues! Coax cables have been re-terminated / activated with new compression fittings and MoCA is online! 
|
Nice!!! Now you're back to a solid internet connection without interference or intermittent issues. It's good when things just work out for the better. Have a good night, bud!! |
2 participants
Modified code to make sure we get correct parameters when changing settings from the WebUI.