Skip to content

Out of range on sequence: show message on tooltip on click annotation #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adrianq merged 47 commits into from
Feb 19, 2025
Merged

Out of range on sequence: show message on tooltip on click annotation #232

adrianq merged 47 commits into from
Feb 19, 2025

Conversation

@p3rcypj
Copy link

@p3rcypj p3rcypj commented Apr 18, 2024 •
edited
Loading

Merge into feature/sync-sequence

📌 References

📝 Implementation

  • Features

    • Out of range annotation
    • Chunk when many Uniprot IDs
    • Created cache wrapper for all requests

  • Minor changes

    • Removed BLAST, was set almost true for all tracks (which I don't quite know if it should be like that)
    • Quick style modification: Gene viewer subtrack
    • Fix loading stop showing when was still loading

🎨 Screenshots

image
image

Screenshots showing: Out of range annotation

@p3rcypj p3rcypj changed the base branch from development to feature/sync-sequence December 31, 2024 03:41
@p3rcypj p3rcypj marked this pull request as ready for review December 31, 2024 12:35
@p3rcypj
Copy link
Author

p3rcypj commented Dec 31, 2024

Note for the cache feature: I used Session Storage to delete the data when the user closes the browser. Unfortunately, that makes also the data not accessible between other windows or tabs. But I think it is best to make the data be deleted when the tab is closed.

@p3rcypj p3rcypj requested a review from tokland January 2, 2025 09:20
tokland
tokland reviewed Jan 2, 2025
View reviewed changes
Copy link

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-line comments:

@p3rcypj p3rcypj requested a review from tokland January 7, 2025 11:15
tokland
tokland reviewed Jan 7, 2025
View reviewed changes
Copy link

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-line comments:

@p3rcypj p3rcypj requested a review from tokland January 19, 2025 04:08
tokland
tokland reviewed Jan 20, 2025
View reviewed changes
Copy link

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some in-line comments:

@adrianq adrianq changed the base branch from feature/sync-sequence to development February 18, 2025 10:40
@adrianq adrianq merged commit 17bad8d into development Feb 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tokland tokland tokland left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@p3rcypj @tokland @adrianq