Refactored CameraThread #266
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahheller
requested review from
MikeKantrowitz,
armadilloz,
batchen1 and
bengold22
as code owners
bengold22
suggested changes
Mar 16, 2025
Contributor
There was a problem hiding this comment.
I would like to understand what the issue was in replay rather than merge this as-is. Switching to Thread instead of Runnable is essentially switching "6" for a "half-dozen", it's semantically the same thing. The only difference I can see is the check at the start to see if the camera is connected, which could have been the only refactoring needed. Moving everything to instance variables doesn't really make any functional sense to me either.
Contributor
|
status? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added error handling so it does not crash if camera is not plugged in.