-
Notifications
You must be signed in to change notification settings - Fork 10
Tinkers 3.0 #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tinkers 3.0 #68
Conversation
Deploying docs with
|
| Latest commit: |
818659f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://535347ea.docs-dp3.pages.dev |
| Branch Preview URL: | https://feat-tinkers-update.docs-dp3.pages.dev |
|
When you get the time @Squidgyface1478 review this, i think ive updated everything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds support for custom table names in the crafting system, along with new image assets and documentation for the Tinkers 3.0 addon.
Key Changes
- Added ability to specify custom crafting table names via metadata in crafting code blocks
- Extended the crafting components to support and display custom table names
- Added multiple PNG image assets for Tinkers addon (item sprites, UI elements, part images)
- Added comprehensive documentation for the Modifier Worktable feature
Reviewed Changes
Copilot reviewed 18 out of 44 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/remark/crafting.ts | Parses metadata to extract custom table names from crafting code blocks |
| src/components/Crafting/util.ts | Added optional customTableName field to Recipe type |
| src/components/Crafting/Table/Table.tsx | Renders custom table name when provided, otherwise defaults to "Crafting Table" |
| src/components/Crafting/Crafting.tsx | Passes custom table name prop to Table component |
| docs/marketplace/Addons/tinkers/Docs/Modifiers/worktable.md | New documentation for Modifier Worktable usage |
| static/img/mc/* | Multiple new PNG image assets for Tinkers addon |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Getting Started: towards the bottom there is an extra "T" at the start of here "TThe Forge Beckons... Craft Your First Tool!"
- Using the Smeltery: Final notes; missing notes about the faucet.
- Gadgetry: plate armour now has actual protection, no longer just cosmetic. ask me for a list
- Gadgetry: Slime beans no longer exist, slime islands now spawn naturally.
- Gadgetry: No mention of Berry bushes or cheese.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 25 out of 66 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Squidgyface1478
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
No description provided.