Skip to content

Conversation

@cardox6
Copy link
Collaborator

@cardox6 cardox6 commented Mar 15, 2023

FAIL test/app/components/Search.test.tsx (8.28 s)
Search
✓ should render the search input (38 ms)
✕ submits the search form with the search value entered by the user (188 ms)

● Search › submits the search form with the search value entered by the user

expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: {"searchValue": "test"}

Number of calls: 0

  30 |
  31 |
> 32 |     expect(mockOnSubmit).toHaveBeenCalledWith({ searchValue: "test" });
     |                          ^
  33 |   });
  34 |
  35 | });

  at Object.toHaveBeenCalledWith (test/app/components/Search.test.tsx:32:26)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a clean up.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With clean up are you referring to line 8?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide more details on the BlurDataUrl?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generated a base64 version of the Placeholder image, so when loading it displays it. If there is a way to make it shorter, or want to remove it -- let me know.

Copy link
Member

@RichardKruemmel RichardKruemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments below the files.
As this is your first PR it is normal that there are more comments and requests from my side. Please don't feel discouraged from it and continue the great work!

@cardox6 cardox6 requested a review from RichardKruemmel April 13, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Politician Header

3 participants