Add challenges for data reads #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unlike fil_read, we don't need to substract one for the step in its creation since fail writes are done after the step execution, so the step was already incremented
crivasr
changed the title
fixed info messages and don't store logs if there is no disagreement
If there is a stack overflow, the stack pointer will point to an address outside of the stack section. If there are no sections next to the stack section then it will cause a segmentation fault for accessing an invalid address
We don't need the final trace of the prover, the verifier can already challenge using his trace and the hashes given by the prover
This reverts commit fd6292a. This change is being worked on a different branch
crivasr
force-pushed
the
initial_value_challenges
branch
from
33e96ca to
7569723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.