fix multiplication in bitcoin script (VMX-CPU-012, VMX-CPU-013) #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crivasr
changed the title
crivasr
force-pushed
the
multiplication-fix
branch
from
f4e650d to
87d99ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modulo and quotient lookup tables were not large enough to cover the full range of values produced during multiplication. Intermediate results correctly ranged from 0 to 127, but after adding the quotient from division by 16 (maximum value 7), results could reach up to 134.
This caused
OP_PICKto sometimes access data out of bounds, leading to one of two issues:InvalidStackOperationerror if the stack had insufficient elements.