-
Notifications
You must be signed in to change notification settings - Fork 100
(Temporary) Add support for Majora's Mask #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Im not suggesting that this should be supported in the initial release of MM support, but: I'd like to mention that there are plenty of MM features that modders may be interested in back-porting and using in oot. For example: material animations, or its improved cutscene system. Just mentioning this so it can be taken into account when designing support for both games! Hope down the line we can easily enable specific MM features in oot |
|
actually I thought of that, I ported the cutscene manager, the actor cutscene and the animated materials to HackerOoT a while ago and I added a checkbox when, while in the OoT game mode, allows you to enable the MM features, though that's a bit untested for now also it toggles all the features at once, I'll try to improve this by adding checkboxes for each feature (and a global button like there is currently) |
|
Great! Am hoping a checkbox like that will be available to non-hacker-oot users as well |
|
yeah it's be available for everyone, no need to enable HackerOoT features |
Co-authored-by: Nokaubure <15821377+Nokaubure@users.noreply.github.com>
This is a temporary draft PR to make my MM work appear in the updater as a pull request (which is a cool new feature you can have on the main branch and the recent release candidate), this is not meant to be reviewed but feel free if you see anything I missed (but it's not ready yet)
This branch implements support for Majora's Mask decomp, a lot is untested (by me) but I was told most features works properly, with the exception of Link skeleton imports (which I'm currently looking at). Also this implements the new features from MM, such as Actor Cutscenes, Animated Materials, the new minimap stuff and of course the new cutscene commands including their preview when possible (you can preview motion blur but it's not highly accurate but still cool, and you can preview the transition general commands), and the other new features I might have forgot about
This is in a usable state but not really review friendly so I plan on splitting all of this in small PRs to make it nice (and also it will be a good opportunity to do a clean-up pass/self review), feel free to report any issues you can have!