Skip to content

Conversation

@andreamileska
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@nakov0301 nakov0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you have forgot to pull the changes to the master branch from the previous PR before you created the new branch. So pleaase do that first. Also the bower_components folder should be excluded from the remote git repository. So please add that to the .gitignore file.

@andreamileska
Copy link
Collaborator Author

I'm not sure if I did it correctly

@nakov0301
Copy link
Collaborator

Please make sure that works locally before you push. I get this error Undefined variable: expenses (View: /Users/nakov/projects/expense-tracker/resources/views/expenses/show.blade.php) once I log in.

@andreamileska
Copy link
Collaborator Author

after I did pull and merge conflicts everything got messed up, and I can't get it back as it was before. It works locally on this url: http://127.0.0.1:8000/expenses/show and another problem now is that it doesn't update the $expenses array as it did with the filtered params

@nakov0301
Copy link
Collaborator

The only problem now is that after login it tries to load the expenses.show view which requires an array of expenses to be passed. So instead of going through the HomeController we can directly redirect to the ExpensesController show page. For this to work, in the LoginController replace the $redirectTo route from /home to this: protected $redirectTo = '/expenses/show';.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants