Skip to content

(Potential FUTURE bug) wrong offset calculation #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pl752 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

(Potential FUTURE bug) wrong offset calculation #1246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/FirebirdSql.Data.FirebirdClient/Client/Managed/FirebirdNetworkHandlingWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,12 @@ public async ValueTask<int> ReadAsync(byte[] buffer, int offset, int count, Canc

public void Write(byte[] buffer, int offset, int count)
{
for (var i = offset; i < count; i++)
for (int i = 0; i < count; i++)
Copy link
Member

@cincuranet cincuranet Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep var here.

_outputBuffer.Enqueue(buffer[offset + i]);
}
public ValueTask WriteAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken = default)
{
for (var i = offset; i < count; i++)
for (int i = 0; i < count; i++)
Copy link
Member

@cincuranet cincuranet Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep var here.

_outputBuffer.Enqueue(buffer[offset + i]);
return ValueTask.CompletedTask;
}
Expand Down