Skip to content

fix multiline call sniff #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhukV merged 2 commits into from
Jun 25, 2025
Merged

fix multiline call sniff #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b1a175
fix multiline call sniff
Lassombria Jun 17, 2025
fc12b0c
Merge branch 'master' into fix-multiline-call-sniff
Lassombria Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/PhpCs/FiveLab/Sniffs/Formatting/WhiteSpaceAroundMultilineCallSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,6 @@ protected function processFunctionCall(File $phpcsFile, int $stackPtr, array $pa
}
}

/**
* Check before multiline call
*
* @param File $phpcsFile
* @param int $stackPtr
*/
private function checkBeforeCall(File $phpcsFile, int $stackPtr): void
{
$tokens = $phpcsFile->getTokens();
Expand Down Expand Up @@ -89,6 +83,7 @@ private function checkBeforeCall(File $phpcsFile, int $stackPtr): void
T_OPEN_SHORT_ARRAY,
T_COLON,
T_ATTRIBUTE_END,
T_RETURN
];

if ($diffLines < 2 && !\in_array($prevToken['code'], $possiblePrevTokens, true)) {
Expand Down
10 changes: 10 additions & 0 deletions ...s/PhpCs/FiveLab/Sniffs/Formatting/Resources/white-space-around-multiline-call/success.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<?php

$res = 23;

$object
->child()
->method(\sprintf(
Expand Down Expand Up @@ -64,4 +66,12 @@ function some(\DOMDocument $dom): string
])]
function withAttributes()
{
$object = new \StdClass();

return $object
->some([
'bla' => 'bla',
'foo' => 'foo',
])
->some2();
}