fix: Use Uses instead of NpmPackage to avoid version conflicts

[TatuLund]

Updated NpmPackage annotation to ensure compatibility with the latest version.

Summary by CodeRabbit

• Bug Fixes

  • Ensures grid resources are correctly included, preventing runtime issues with the radio selection column.

• Performance

  • Slightly reduces bundle size by removing an unnecessary legacy dependency.

• Chores

  • Updated internal annotations/dependency usage to align with platform conventions and improve compatibility.

[coderabbitai]

Walkthrough

Replaced an @NpmPackage annotation with an added @Uses(Grid.class) on GridRadioSelectionColumn, retained @Uses(RadioButtonGroup.class), added an import for Grid and a comment indicating the indirect @NpmPackage dependency.

Changes

Cohort / File(s)	Summary
Annotation and import update in GridRadioSelectionColumn src/main/java/com/flowingcode/vaadin/addons/gridhelpers/GridRadioSelectionColumn.java	Removed @NpmPackage(value = "@vaadin/polymer-legacy-adapter", version = "24.3.2"); added import com.vaadin.flow.component.grid.Grid;; added @Uses(Grid.class) while retaining @Uses(RadioButtonGroup.class); inserted comment // Indirectly ensure @NpmPackage(value = "@vaadin/polymer-legacy-adapter", version = "x.x.x") above the new @Uses(Grid.class) annotation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Add explicit usage of RadioButtonGroup #127 — Also modifies annotations on GridRadioSelectionColumn, specifically adding @Uses(RadioButtonGroup.class) which this change retains.

Suggested reviewers

• paodb

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly states the primary change of replacing the NpmPackage annotation with the Uses annotation to resolve version conflicts, which directly matches the modifications made in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/main/java/com/flowingcode/vaadin/addons/gridhelpers/GridRadioSelectionColumn.java (1)

28-28: Remove unused import.

The NpmPackage import is no longer used since the annotation was removed. Clean up by removing this import.

Apply this diff to remove the unused import:

-import com.vaadin.flow.component.dependency.NpmPackage;

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0eed713 and f8dadc8.

📒 Files selected for processing (1)

• src/main/java/com/flowingcode/vaadin/addons/gridhelpers/GridRadioSelectionColumn.java (1 hunks)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/main/java/com/flowingcode/vaadin/addons/gridhelpers/GridRadioSelectionColumn.java (1)

39-40: Excellent approach to avoid version conflicts.

Using @Uses(Grid.class) instead of directly pinning @NpmPackage(version = "24.3.2") allows Grid to manage the @vaadin/polymer-legacy-adapter version automatically. This ensures the dependency version stays in sync with the Grid component version, preventing conflicts as Vaadin is upgraded.

Based on past review comments, Grid.class provides this dependency across multiple Vaadin versions (23.3, 23.6, 24.0, 24.9), so this approach is validated.

Optional: Consider clarifying the comment.

The comment is clear, but you could make it slightly more explicit:

-// Indirectly ensure @NpmPackage(value = "@vaadin/polymer-legacy-adapter", version = "x.x.x")
+// Grid.class provides @NpmPackage for @vaadin/polymer-legacy-adapter

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8dadc8 and 63a138b.

📒 Files selected for processing (1)

• src/main/java/com/flowingcode/vaadin/addons/gridhelpers/GridRadioSelectionColumn.java (1 hunks)

🔇 Additional comments (1)

src/main/java/com/flowingcode/vaadin/addons/gridhelpers/GridRadioSelectionColumn.java (1)

24-24: LGTM! Import necessary for the @uses annotation.

The Grid import is required for the @Uses(Grid.class) annotation added below and is correctly placed.