forked from viritin/mopo
-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/update to original mopo repo #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AuDuarte
wants to merge
26
commits into
main
Choose a base branch
from
feat/update-to-original-mopo-repo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added MCP friendly documentation
Updated the version of the mopo dependency to 0.0.6.
Modifies the implementation of the constructor and its parameters. Modifies the implementation of the setValue method. Creates a method to set date format.
Add the getGridRows method. Apply formatting to the code.
Add filterAndSelectFirstMultiSelect method to allow receiving a list of parameters and making multiple selections in the MultiSelectComboBox.
Use DatePickerPW from original repo to pass DatePickerIT. Use GridPw.getCell() from original repo to pass GridPlaywrightIT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to stay up to date with the original repo, all changes were analyzed.
Direct changes from original
GridPW
Combobox
Note: Dramafinder also offers support for everything but Grid and Combobox. Besides support for many Vaadin elements, it also offers an abtract base IT class, among other features, like useful interfaces
DatePickerPW, DateTimePickerPW, TimePickerPW
DatePickerPW
FC's version had:
Viritin's version was kept for this class. While dateFormat adds the feature of handling different formats, it causes issues when running tests. This is at least due to not being initialized, but there may be other issues. Besides, this changes do not match what is offered by DateTimePickerPW.
TimePickerPW
Additional features