Skip to content

Conversation

@tomusdrw
Copy link
Member

@tomusdrw tomusdrw commented Jan 15, 2026

Perf results:

== before
==                 min: 4054.6 [μs]
==                 max: 35782.4 [μs]
==                 mean: 12099.1 [μs]
==                 median: 11188.8 [μs]
==                 stdDev: 4575.2 [μs]
==                 p90: 17919.5 [μs]
==                 p99: 21330.7 [μs]

== after
==                 min: 3948.3 [μs]
==                 max: 25640.1 [μs]
==                 mean: 10940.5 [μs]
==                 median: 9877.1 [μs]
==                 stdDev: 4423.6 [μs]
==                 p90: 17457.6 [μs]
==                 p99: 19910.7 [μs]

@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

A new public WASM-exported function verify_header_seals is added to the bandersnatch library that verifies both a header seal and entropy value using IETF VRF verification, returning a 65-byte result containing status and two 32-byte hashes.

Changes

Cohort / File(s) Summary
VRF Header and Entropy Verification
bandersnatch/src/lib.rs
Added verify_header_seals() function that deserializes a signer public key, performs IETF VRF verification on a seal, constructs an entropy payload by prefixing entropy\_prefix to the seal, verifies entropy via IETF VRF, and returns a 65-byte vector encoding verification status and two 32-byte hashes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Add function to generate seal #23 — Introduces generate_seal function for producing VRF output/proof, complementing this PR's verify_header_seals verification logic for the same seal/VRF functionality.

Suggested reviewers

  • DrEverr
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly summarizes the main change: a single function that verifies both header seal and entropy together, matching the core functionality added to lib.rs.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description check ✅ Passed The PR description provides performance benchmark data showing improvements in execution time metrics (min, max, mean, median, stdDev, p90, p99) for the new implementation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@tomusdrw tomusdrw merged commit 92ff682 into main Jan 16, 2026
2 checks passed
@tomusdrw tomusdrw deleted the td-seals branch January 16, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants