Skip to content

Conversation

@tomusdrw
Copy link
Member

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

Introduces a new Rollup plugin called resolveLocalPackages that resolves three local @typeberry packages to local file paths during the build process. Adds a path import and reorders plugins to execute the new resolver before wasm and dts plugins. Adds an external rule to exclude local @typeberry packages from bundling.

Changes

Cohort / File(s) Summary
Rollup plugin for local package resolution
rolldown.config.js
Adds resolveLocalPackages plugin with resolveId hook mapping @typeberry packages to local paths; reorders plugins execution; adds external regex rule for @typeberry-\* packages; imports path module

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset. Add a pull request description explaining the motivation, implementation details, and impact of the rolldown.config.js changes.
Title check ❓ Inconclusive The title 'hacky solution to bundle bandersnatch' is vague and does not clearly convey what the actual change is about. The term 'hacky solution' is non-descriptive, and 'bandersnatch' lacks context without domain knowledge. Clarify the title to specifically describe the change, such as 'Add resolveLocalPackages plugin to exclude @typeberry packages from bundling' or similar.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@tomusdrw tomusdrw merged commit bd1a174 into main Jan 20, 2026
4 checks passed
@tomusdrw tomusdrw deleted the td-avoid-bundling branch January 20, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants