Skip to content

Conversation

@FollowTheProcess
Copy link
Owner

Summary

@FollowTheProcess FollowTheProcess added the refactoring Refactoring label Nov 17, 2024
@codecov
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.55%. Comparing base (0550f44) to head (aff1f03).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/flag/set.go 95.83% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   91.62%   91.55%   -0.08%     
==========================================
  Files           7        7              
  Lines        1301     1290      -11     
==========================================
- Hits         1192     1181      -11     
  Misses         77       77              
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FollowTheProcess FollowTheProcess merged commit 6360e79 into main Nov 17, 2024
9 checks passed
@FollowTheProcess FollowTheProcess deleted the refactor/remove-entry-indirection branch November 17, 2024 08:42
FollowTheProcess added a commit that referenced this pull request Dec 3, 2025
* Remove flag.Entry indirection in favour of an interface

* Minor tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants